Re: [LTP] [PATCH v3 2/2] device-drivers: block: fixes

[<ale...@or...>]

Hi!

On 09/17/2013 08:25 PM, ch...@su... wrote:
> Hi!
>> I wonder if it wouldn't be easier to enter the directory and make the
>> kernel part Makefile to be noop if there is no kernel-devel package or
>> if the kernel version is not new enough.
>>
>> Ideally the makefile in the kernel part should look like:
>>
>>
>> top_srcdir	?= ../../../..
>>
>> include $(top_srcdir)/include/mk/env_pre.mk
>>
>> REQ_VERSION_MAJOR       = 3
>> REQ_VERSION_PATCH       = 7
>>
>> MODULE_NAME = ltp_foo_bar
>>
>> include $(top_srcdir)/include/mk/module.mk
>>
>>
>> And the rest of the magic should be in the module.mk file.
>>
>> Then:
>>
>> 1) make in the dir is noop if devel package is missing or
>>     version is too old
>>
>>     - the parent Makefile has only subdirs defined, no need
>>       for additional magic there
>>
>> 2) module is build
>>
>> 3) if module was build installed
>       if module was build, i.e. the .ko file exist install it
>       on install, dtto for clean
>
Yeah, true... I forgot about version checking and kernel-devel, OK, I'll 
add it to module.mk. I'm not sure about first include you suggested... 
it will be included when make go to kernel tree.

Thanks,
Alexey