Re: [LTP] [PATCH] mount/mount06.c: fix a compile error

[Benoit M. <Ben...@ar...>]

In the other hand Dan's patch gives a hint about *why* it's failing to compile, which is nice.

> -----Original Message-----
> From: Benoit Marcot [mailto:Ben...@ar...]
> Sent: 30 July 2013 09:19
> To: DAN LI; gao...@cn...
> Cc: LTP list
> Subject: Re: [LTP] [PATCH] mount/mount06.c: fix a compile error
>
> Hi!
>
> I had the same problem to compile the latest commits; I patched in the same
> way as testcases/kernel/security/tomoyo/tomoyo_filesystem_test.c:
>
> #ifndef MS_MOVE
> #define MS_MOVE         8192
> #endif
>
> Benoit
>
> > -----Original Message-----
> > From: DAN LI [mailto:li...@cn...]
> > Sent: 30 July 2013 05:16
> > To: gao...@cn...
> > Cc: LTP list
> > Subject: Re: [LTP] [PATCH] mount/mount06.c: fix a compile error
> >
> > On 07/30/2013 11:40 AM, Wanlong Gao wrote:
> > > On 07/30/2013 11:31 AM, DAN LI wrote:
> > >>
> > >> The definitions of MS_PRIVATE and MS_MOVE were only added to glibc
> > >> headers in version 2.12.
> > >>
> > >> If the version of glibc is older than 2.12, define these two flags.
> > >>
> > >> Signed-off-by: DAN LI <li...@cn...>
> > >> ---
> > >>  testcases/kernel/syscalls/mount/mount06.c |    5 +++++
> > >>  1 files changed, 5 insertions(+), 0 deletions(-)
> > >>
> > >> diff --git a/testcases/kernel/syscalls/mount/mount06.c
> > >> b/testcases/kernel/syscalls/mount/mount06.c
> > >> index acfb22d..ab1a472 100644
> > >> --- a/testcases/kernel/syscalls/mount/mount06.c
> > >> +++ b/testcases/kernel/syscalls/mount/mount06.c
> > >> @@ -31,6 +31,11 @@
> > >>  #include "usctest.h"
> > >>  #include "safe_macros.h"
> > >>
> > >> +#if !(__GLIBC_PREREQ(2, 12))
> > >
> > > Why not do like below?
> >
> > I think it also clearly shows the reason why this definition should
> > exist here(glibc version related).
> >
> > Regards,
> > DAN LI
> >
> > > #ifndef MS_MOVE
> > > #define xxx
> > > #define xxx
> > > #endif
> > >
> > > Wanlong Gao
> > >
> > >> +#define MS_MOVE   8192
> > >> +#define MS_PRIVATE        (1 << 18)
> > >> +#endif
> > >> +
> > >>  #define MNTPOINT_SRC      "mnt_src"
> > >>  #define MNTPOINT_DES      "mnt_des"
> > >>  #define LINELENGTH        256
> > >>
> > >
> > >
> >
> >
> >
> > ----------------------------------------------------------------------
> > -------- Get your SQL database under version control now!
> > Version control is standard for application code, but databases havent
> > caught up. So what steps can you take to put your SQL databases under
> > version control? Why should you start doing it? Read more to find out.
> > http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.c
> > lk
> > trk
> > _______________________________________________
> > Ltp-list mailing list
> > Ltp...@li...
> > https://lists.sourceforge.net/lists/listinfo/ltp-list
>
>
> -- IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended recipient,
> please notify the sender immediately and do not disclose the contents to any
> other person, use it for any purpose, or store or copy the information in any
> medium.  Thank you.
>
>
> ------------------------------------------------------------------------------
> Get your SQL database under version control now!
> Version control is standard for application code, but databases havent caught
> up. So what steps can you take to put your SQL databases under version
> control? Why should you start doing it? Read more to find out.
> http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clk
> trk
> _______________________________________________
> Ltp-list mailing list
> Ltp...@li...
> https://lists.sourceforge.net/lists/listinfo/ltp-list


-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.