Re: [LTP] [PATCH] shmget/shmget01.c: cleanup and attach SHM_NORESERVE to shmflg

[DAN LI <li...@cn...>]

On 05/29/2013 07:27 PM, Caspar Zhang wrote:
> On 05/29/2013 06:25 PM, DAN LI wrote:
>> On 05/29/2013 05:18 PM, Jan Stancek wrote:
>>>
>>> ----- Original Message -----
>>>> From: "DAN LI" <li...@cn...>
>>>> To: "LTP list" <ltp...@li...>
>>>> Sent: Wednesday, 29 May, 2013 10:58:47 AM
>>>> Subject: [LTP] [PATCH] shmget/shmget01.c: cleanup and attach SHM_NORESERVE to shmflg
>>>>
>>>>
>>>> 1. Remove useless comments
>>>>
>>>> 2. Revise code to follow ltp-code-style
>>>>
>>>> 3. Add SHM_NORESERVE to shmflg to test
>>>
>>> Can you add some description why you are adding this flag?
>>
>> Actually, we are trying to complete test cases and expand
>> the test scope of LTP.
>>
>> So, it is just for completeness of this case.
> 
> Would it be better to split the code-style fix and the functional/feature part?

Agree.

Coming V2 will make it.

Regards,
DAN LI
> 
> Caspar
>