From: Mike F. <va...@ge...> - 2013-05-10 15:36:10
|
On Friday 10 May 2013 04:30:00 Wanlong Gao wrote: > On 05/10/2013 12:20 AM, Mike Frysinger wrote: > > On Thursday 09 May 2013 09:32:32 ch...@su... wrote: > >>> +#ifdef __linux__ > >>> +int TST_TOTAL = 13; > >>> +#else > >>> > >>> int TST_TOTAL = 10; > >>> > >>> +#endif > >>> > >>> static int sem_id_1 = -1; > >>> > >>> @@ -57,8 +65,14 @@ static void func_sval(void); > >>> > >>> static void func_rmid(void); > >>> static void child_cnt(void); > >>> static void child_pid(void); > >>> > >>> +#ifdef __linux__ > >>> +static void func_iinfo(int); > >>> +static void func_sinfo(void); > >>> +static void func_sstat(int); > >>> +#endif > >> > >> Well the only part of the LTP that we promise that will build and run on > >> anything else than Linux is Open Posix Testsuite, so in my opinion these > >> ifdefs are not needed. Has anybody different opinion? > > > > i agree -- drop the __linux__ check, especially under testcases/kernel/ > > ... the "kernel" there is "linux". > > So, you mean drop the "sgi" as well? scrubbing it from testcases/kernel/syscalls/sighold/sighold02.c makes sense. SGI is dead and so is IRIX. if they want to run tests against their system, then can download an older version of LTP. -mike |