Re: [LTP] [PATCH v2 3/3] setns: add new syscall test setns02

[<ch...@su...>]

Hi!
> > > +static void setup(void)
> > > +{
> > > +	char tmp[PATH_MAX];
> > > +
> > > +	tst_require_root(NULL);
> > > +
> > > +	/* runtime check if syscall is supported */
> > > +	syscall(__NR_setns, -1, 0);
> > > +
> > 
> > What happens when the syscall is not supported? The call should
> > return
> > -1 and errno should be set to ENOSYS but the return value is not
> > checked, I'm puzzled.
> 
> It's a bit unfortunate name collision with syscall macro defined
> in linux_syscall_numbers.h. That macro contains check for ENOSYS.

Ah, now I remeber.

We really should change that one. Any volunteers?

-- 
Cyril Hrubis
ch...@su...