Re: [LTP] [PATCH 1/4] add libnuma_helper

[Garrett C. <yan...@gm...>]

On Mon, May 28, 2012 at 4:39 AM, Jan Stancek <jst...@re...> wrote:
>
> A library to share NUMA helper functions shared by
> multiple testcases.
>
> Signed-off-by: Jan Stancek <jst...@re...>

One comment...

+			tst_resm(TFAIL, "get_allowed_nodes, i >= num_allowed_nodes: "
+			    "%d > %d", i, num_nodes);

1. I would just remove this because it's obvious from the API
definition what's going on when it sets ret to -3.
2. I would add a break there so it doesn't iterate through the loop
more than necessary.

Cheers,
-Garrett