Re: [LTP] [PATCH v3 2/2] aio_suspend-8-1: use aio_error to check completion instead

[Cyril H. <ch...@su...>]

Hi!
>  	if (ret) {
>  		printf(TNAME " Error at aio_suspend() %d: %s\n", errno, strerror(errno));
>  		for (i=0; i<NUM_AIOCBS; i++)
> @@ -211,7 +180,9 @@ main ()
>  		if (i == WAIT_FOR_AIOCB)
>  			continue;
>  
> -	  	err = aio_error(aiocbs[i]);
> +		do {
> +			err = aio_error(aiocbs[i]);
> +		} while (err == EINPROGRESS);

I've looked carefully through the test and this part shouldn't be needed
as when we got here, the singnal handler for list completion was
allready called, or not?

I think that simple err = aio_error(aiocbs[i]) should work in this case.

The rest of the patch seems to be correct.

>  		ret = aio_return(aiocbs[i]);
>  
>  		if ((err != 0) && (ret != BUF_SIZE)) {

-- 
Cyril Hrubis
ch...@su...