Re: [LTP] [PATCH 02/21] lib/self_exec: Remove extra argument from tst_resm function call

[Markos C. <Mar...@im...>]

On 01/04/2012 02:20 PM, Cyril Hrubis wrote:
> Hi!
>> On 01/03/2012 09:57 AM, Markos Chandras wrote:
>>> On 01/03/2012 09:50 AM, Garrett Cooper wrote:
>>>> On Tue, Jan 3, 2012 at 1:35 AM, Markos Chandras
>>>> <Mar...@im...>    wrote:
>>>>> Hi, please review the attached patch
>>>>
>>>>       Converting the function to tst_brkm and removing the tst_exit call
>>>> below it would be better.
>>>> Thanks!
>>>> -Garrett
>>> Agreed, but to make this consistent, all the tst_resm&&   tst_exit pairs
>>> should be replaced with tst_brkm. I will prepare a patch
>>>
>> Here is a patch that converts all tst_resm&&  tst_exit calls to
>> tst_brkm. Please review it.
>
> Commited, thanks.
>
> And please add better patch description next time.
>
Thanks. I will next time. However, I think there is a problem with the 
patch now that I had some time to look at in again. The last chunk is 
wrong. This statement

+	    tst_brkm(TBROK, "Could not change to %s for child", child_dir);

should be

+	    tst_brkm(TBROK, NULL, "Could not change to %s for child", child_dir);

Could you please commit this fix as well?

-- 
markos