Re: [LTP] [PATCH] cron: fix fail due to rsyslogd dead

[Peng H. <pe...@cn...>]

Any other comments of the following patch?

-- 
Best Regards,
Peng

Peng Haitao said the following on 2011-6-30 11:14:
> 
> Garrett Cooper said the following on 2011-6-30 9:21:
>>     This seems like it would produce undesirable results when what you
>> want to do is actually make sure that the syslog tests bring rsyslogd
>> back to life after the test is done; all tests should setup any
>> necessary environment to run the test, and restore the original state
>> of the system if at all possible -- otherwise it becomes a mess
>> getting everything to integrate properly. Restarting rsyslogd after
>> the syslog tests are done isn't that hard, so that should be done
>> there.
> 
> The syslog tests restart rsyslogd to restore the original state, 
> but ltp-pan will kill rsyslogd when it kills orphans. 
> 
> rsyslogd can use setsid() or ioctl() to make itself a daemon. 
> In RHEL, rsyslogd uses ioctl(). But TIOCNOTTY ioctl cannot 
> remove it from its current process group, 
> so ltp-pan will still kill it.
> 

Peng Haitao said the following on 2011-6-17 17:45:
> 
> When executing "/opt/ltp/runltp" to test all the default cases, rsyslogd will
> be dead after testing the cases of syslog, but the case of cron need rsyslogd
> being running, otherwise cron will fail.
> 
> Signed-off-by: Peng Haitao <pe...@cn...>
> ---
>  testcases/commands/cron/cron_tests.sh |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/testcases/commands/cron/cron_tests.sh b/testcases/commands/cron/cron_tests.sh
> index a627ddb..49e29a6 100644
> --- a/testcases/commands/cron/cron_tests.sh
> +++ b/testcases/commands/cron/cron_tests.sh
> @@ -64,6 +64,11 @@ LOCTMP=${PWD}/tmp
>  TFAILCNT=0
>  RC=0
>  
> +# Restart rsyslog service
> +if command -v rsyslogd >/dev/null 2>&1; then
> +	/etc/init.d/rsyslog restart
> +fi
> +
>  # Test #1
>  # Test if crontab <filename> installs the crontab file and cron schedules the 
>  # job correctly.

-- 
Best Regards,
Peng Haitao