From: Harsh B. <ha...@li...> - 2010-08-05 10:00:02
|
On 08/03/2010 09:56 PM, Garrett Cooper wrote: > On Tue, Aug 3, 2010 at 3:04 AM, Harsh Prateek Bora > <ha...@li...> wrote: > >> Current testcase for setrlimit for parameter RLIMIT_FSIZE >> does not convey the number of bytes actually written from >> child process to parent, as the child process writes to its >> own copy of global variable. This patch introduces a pipe >> to send the information from child to the parent process. >> > 1. The style's a bit wonky, but that might be the fault with how the > original test was written. > So, what change do you suggest in the style? Can you be precise? > 2. You aren't checking how many bytes are actually being read/written > in your patch but assuming that the stream `bytes' is correctly > written each time ;)... > I hope you are talking about verifying expected number of bytes after reading/writing from pipe, shall do that. > Thanks, > -Garrett > |