From: Rishikesh K R. <ris...@in...> - 2010-05-05 04:48:20
|
Thanks matt. This has been already applied and released to April month LTP tarball. Commit ID : d9f3d25b9db35073c7104b759d526869d9867692 Warm Regards Rishi Linux Tech Centre IBM-ISTL, Manyata Bangalore Matt Helsley <matthltc@us.ibm. com> To su...@li... 05/05/2010 04:05 cc AM Rishikesh K Rajak/India/IBM@IBMIN, ltp...@li... Subject Re: [LTP] PATCH : test_fs_bind testscript for busybox machines On Mon, Apr 26, 2010 at 12:06:51PM +0530, Suzuki Poulose wrote: > Hi, > > The test_fs_bind testscript hangs indefinitely when run on a machine > where busybox applets are used. > > The test hangs while trying to restore the mounts after a test run. > > > This happens because the "xargs" applet from busybox doesn't > understand the --max-args=1 option. Thus, the mounts from the test > are not removed and this goes on in a loop, indefinitely. > > This could be avoided by using "-n" option which is supported by > both the implementations of xargs. > > > Attached the patch here. > > Thanks > > Suzuki Just noticed this thread. Looks good, thanks! Acked-by: Matt Helsley <mat...@us...> > > Signed-off-by: Suzuki K P <su...@in...> > > Index: ltp/testscripts/test_fs_bind.sh > =================================================================== > --- ltp.orig/testscripts/test_fs_bind.sh 2009-12-22 03:28:25.000000000 +0000 > +++ ltp/testscripts/test_fs_bind.sh 2010-04-26 05:50:41.000000000 +0000 > @@ -238,7 +238,7 @@ > # new mounts around and will never remove mounts outside the test > # directory > ( while grep_proc_mounts ; do > - grep_proc_mounts | awk '{print $2}' | xargs -r --max-args=1 umount -l > + grep_proc_mounts | awk '{print $2}' | xargs -r -n 1 umount -l > done ) >& /dev/null > > # mount list and exit with 0 > ------------------------------------------------------------------------------ > _______________________________________________ > Ltp-list mailing list > Ltp...@li... > https://lists.sourceforge.net/lists/listinfo/ltp-list |