Re: [LTP] 2010-02-01 cvs make problem

[Stephen S. <sd...@ty...>]

On Mon, 2010-02-01 at 12:02 -0800, Garrett Cooper wrote:
> On Mon, Feb 1, 2010 at 6:20 AM, Stephen Smalley <sd...@ty...> wrote:
> > On Mon, 2010-02-01 at 00:44 -0800, Garrett Cooper wrote:
> >> On Mon, Feb 1, 2010 at 12:09 AM, Mitani <mi...@ry...> wrote:
> >> > Hi,
> >> >
> >> > I tried to build 2010-02-01 cvs in RHEL5.4 system.
> >> > (Archecture : x86 and x86_64)
> >> >
> >> >
> >> > "make" failed with following message:
> >> > ------------
> >> > [...]
> >> > make[5]: Entering directory
> >> > `/home/LTP/ltp-2010-02-01/testcases/kernel/security/selinux-testsuite/refpol
> >> > icy'
> >> > (cd
> >> > "/home/LTP/ltp-2010-02-01/testcases/kernel/security/selinux-testsuite/refpol
> >> > icy/policy_files/generic" && cat test_global.te test_bounds.te
> >
> > Hmm...this indicates that your Makefile rewrite still isn't working
> > properly on RHEL5, where it is supposed to use the files under
> > refpolicy/policy_files/redhat-5 instead of generic.
> >
> >> > test_capable_file.te test_capable_net.te test_capable_sys.te
> >> > test_dyntrace.te test_dyntrans.te test_entrypoint.te test_execshare.te
> >> > test_exectrace.te test_execute_no_trans.te test_fdreceive.te test_file.te
> >> > test_inherit.te test_ioctl.te test_ipc.te test_link.te test_mkdir.te
> >> > test_open.te test_ptrace.te test_readlink.te test_relabel.te test_rename.te
> >> > test_rxdir.te test_setattr.te test_setnice.te test_sigkill.te test_stat.te
> >> > test_sysctl.te test_task_create.te test_task_getpgid.te
> >> > test_task_getsched.te test_task_getsid.te test_task_setpgid.te
> >> > test_task_setsched.te test_transition.te test_wait.te) > test_policy.te
> >> > cat: /selinux/mls: No such file or directory
> >
> > And this suggests that the tester does not have SELinux enabled in his
> > kernel.  You shouldn't enable the SELinux testsuite unless SELinux is
> > enabled in the kernel.  You can test with something akin to:
> > if [ -x /usr/sbin/selinuxenabled ] && selinuxenabled; then
> >        <run selinux testsuite>
> > fi
> >
> >
> >> > make[6]: Entering directory
> >> > `/home/LTP/ltp-2010-02-01/testcases/kernel/security/selinux-testsuite/refpol
> >> > icy'
> >> > Compiling targeted test_policy module
> >> > test_policy.te:129:ERROR 'syntax error' at token 'typebounds' on line 93991:
> >> > # Definition of boundary relationship
> >> > typebounds test_bounds_parent_t test_bounds_child_t;
> >> > /usr/bin/checkmodule:  error(s) encountered while parsing configuration
> >> > /usr/bin/checkmodule:  loading policy configuration from tmp/test_policy.tmp
> >
> > And apparently your Makefile logic to exclude test_bounds.te if
> > CHECKPOLICYVERS is not 24 isn't working either, although it wouldn't try
> > if it was using the right subdirectory.
> 
> Mitani-san -- could you do the following please?
> 
> 1. cat out your /etc/issue file.
> 2. Provide the output for $srcdir/scripts/detect_distro.sh

Doesn't seem to be stripping the minor version.
$ ./scripts/detect_distro.sh 
redhat-5.4
$ ./scripts/detect_distro.sh  -m
redhat-5.4

Also, the filter-out test_bounds.te has to come after the definition of POLICY_FILES.

-- 
Stephen Smalley
National Security Agency