Re: [LTP] [PATCH] fix compiling error on ia64 platform (ltp-full-20091130)

[Garrett C. <yan...@gm...>]

On Fri, Dec 18, 2009 at 10:31 AM, Mike Frysinger <va...@ge...> wrote:
> On Tuesday 15 December 2009 14:39:24 Garrett Cooper wrote:
>> Until this issue is resolved (I ran into problems trying to use
>> crossdev, so I'll have to manually inspect headers after I track down
>> which versions are used in the Redhat distros specified), please
>> remember that you _can_ always comment out the line which says:
>>
>> /* Define to 1 if you have the <asm/ptrace.h> header file. */
>> #define HAVE_ASM_PTRACE_H 1
>>
>> Actually, I think I'll just remove that header check if the build
>> passes unless Mike objects, because we really shouldn't be
>> #include'ing asm/* headers without having a good reason to do so
>> because it results in pain of this magnitude...
>
> i guess i dont know why you've made changes to the ptrace.h header at all.
> the original one i committed still works for me on bfin/ia64/x86/x86_64.  i
> dont recall any questions being posted to the list about the logic, just
> random shuffling to try and "fix" errors that i have yet to see.

    You're right. I've reverted to your original copy and everything
just works on my Gentoo box. I need to determine if our headers are
f'ed up at work -- I wouldn't be surprised if that's the case.
    If others need for this to be fixed on their toolchains /
platforms, we'll definitely need access to the tools and/or maybe the
hardware in order to verify that the changes are sane.
Thanks as always :\,
-Garrett