Re: [LTP] [FIX PATCH] open_posix_pthread_equal_2-1.c

[Garrett C. <yan...@gm...>]

On Wed, Jul 29, 2009 at 3:10 AM, naresh kamboju<nar...@gm...> wrote:
> Hi,
>
> I have notice HUNG status for pthread_equal/2-1.c under posix test suite.
> conformance/interfaces/pthread_equal/2-1.test:execution:HUNG
>
> This because of while(do_it)loop is behaving as while(1).
> do_it updated value from one thread is not reflecting in the other
> thread because the type is not proper.
> I have changed the type from char -> volatile int
>
> I have shared results before and after this patch.
>
> Before PATCH:
> conformance/interfaces/pthread_equal/2-1.test:execution:HUNG
>
> After PATCH:
> conformance/interfaces/pthread_equal/2-1.test:execution:PASS
>
> I have attached patch and below.
> Please review the same.
>
> Best regards,
> Naresh Kamboju
>
> Signed-off-by: Naresh Kamboju < nar...@gm... >
>
> diff -Naurb a/testcases/open_posix_testsuite/conformance/interfaces/pthread_equal/2-1.c
> b/testcases/open_posix_testsuite/conformance/interfaces/pthread_equal/2-1.c
> --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_equal/2-1.c 2005-06-03
> 22:01:47.000000000 +0530
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_equal/2-1.c 2009-07-29
> 14:27:05.000000000 +0530
> @@ -80,7 +80,7 @@
>  /***********************************    Test cases
> *****************************************/
>  /********************************************************************************************/
>
> -char do_it=1;
> +volatile int do_it=1;
>  unsigned long count_ope=0;
>  #ifdef WITH_SYNCHRO
>  sem_t semsig1;

Naresh,
    Have you contributed this back to openposix, or at the very least
filed a bug about this that can be referenced?
Thanks,
-Garrett