Re: [LTP] [RFC] [PATCH] build system cleanup

[Mike F. <va...@ge...>]

On Saturday 04 July 2009 03:18:10 Garrett Cooper wrote:
> 2. SOURCES =, TARGETS = is just plain silly as it wastes internal
> variables and increases Makefile length. This is better: TARGETS :=
> $(patsubst %.c,%.o,$(wildcard *.c))

well, the default could do that, but we shouldnt force all subdirs to operate 
this way as it makes the build system too strict.  think about support .c 
files that get included into other .c files, or linked into the final app.

> 3. LOADLIBES is less of a standard variable than LDLIBS is.

i think splitting between the two should be OK ... LDLIBS for system libs 
(i.e. -lfoo) and LOADLIBES for internal LTP libs (i.e. libltp.a).

> 4. Subdirectories that need to be traversed by make can generally be
> determined with $(patsubst %/Makefile,%,$(wildcard */Makefile)).

again, a default like this is good, but it shouldnt be required.
-mike