Re: [LTP] [RFC][PATCH] Add cpu architecrute check

[Mike F. <va...@ge...>]

On Thursday 04 June 2009 03:23:17 Nobuhiro Iwamatsu wrote:
> --- a/Makefile
> +++ b/Makefile
> +ifndef ARCH
> +# copy from Makefile in linux kernel
> +ARCH := $(shell uname -m

executing uname to detect build/target systems is never acceptable.

> --- a/testcases/kernel/syscalls/fallocate/Makefile
> +++ b/testcases/kernel/syscalls/fallocate/Makefile
> @@ -20,8 +20,14 @@
>  CFLAGS += -I../../../../include -Wall
>  LDLIBS += -L../../../../lib -lltp
>
> +# This system call is suported in i386, x86_64 and ppc only.
> +ifneq (,$(findstring $(ARCH), i386 x86_64 ppc))
>  SRCS    = $(wildcard *.c)
>  TARGETS = $(patsubst %.c,%,$(SRCS))
> +else
> +SRCS    =
> +TARGETS =
> +endif

atm, better to put the ifdef logic into the test itself.  look at some of the 
other tests that get stubbed out in the syscalls dir.
-mike