Re: [LTP] [FAILURE] ltp/testcases/misc/tcore_patch_test_suites

[gowrishankar <gom...@li...>]

I have made it to compile and run with below patch.
Using proper extended asm stops this problem.
---
Below patch uses gcc's extended asm instead of basic inlines on this test
which stops compilation problem with newer gcc's (v4).

Signed-off-by: Gowrishankar M <gow...@li...>

---
Index: ltp/testcases/misc/tcore_patch_test_suites/tcore.c
===================================================================
--- ltp.orig/testcases/misc/tcore_patch_test_suites/tcore.c    
2008-12-17 18:28:00.000000000 -0500
+++ ltp/testcases/misc/tcore_patch_test_suites/tcore.c    2008-12-17 
18:29:43.000000000 -0500
@@ -126,7 +126,7 @@
      {
     char buf[16];
     sprintf(buf, "%d%d\n", pid, pid);
-    __asm__ ("movups %0, %%xmm1;"::"m"(buf));
+    asm volatile ("movups (%0), %%xmm1;"::"r" (buf):"memory");
     }
         sleep(1);
       }
@@ -163,8 +163,8 @@
     char buf1[16];
     sprintf(buf, "%d%d\n", pid, pid);
     sprintf(buf1,"%d",d2);
-    __asm__ ("movups %0,%%xmm2;"::"m"(buf));
-    __asm__ ("movups %0, %%xmm5;"::"m"(buf));
+    asm volatile ("movups (%0), %%xmm2;":: "r" (buf):"memory");
+    asm volatile ("movups (%0), %%xmm5;":: "r" (buf):"memory");
     }
         *junk = 0;
       }

---
Thanks,
Gowri

Subrata Modak wrote:
> Dear Guo,
>
> The tcore_patch_test_suite was added to LTP on Fri Jan 17 22:07:55 2003
> UTC, with contribution from you. As i try to compile it today, i get the
> following error:
>
> [tcore_patch_test_suites]$ make
> gcc  -o tcore tcore.c -lm -lpthread
> tcore.c: In function ‘producer’:
> tcore.c:129: error: memory input 0 is not directly addressable
> tcore.c: In function ‘consumer’:
> tcore.c:166: error: memory input 0 is not directly addressable
> tcore.c:167: error: memory input 0 is not directly addressable
> make: *** [tcore] Error 1
>
>
> $ uname -a
> Linux 2.6.18-92.el5 #1 SMP Tue Apr 29 13:16:12 EDT 2008 i686 i686 i386
> GNU/Linux
>
> Can you please let me know:
> 1) Any fix for this Failure ?
> 2) Relevance of this test case today, whether they need to be there in
> LTP or not ?
>
> Thanks in advance.
>
> Regards--
> Subrata
>
>
>
> ------------------------------------------------------------------------------
> SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
> The future of the web can't happen without you.  Join us at MIX09 to help
> pave the way to the Next Web now. Learn more and register at
> http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
> _______________________________________________
> Ltp-list mailing list
> Ltp...@li...
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>