Menu
▾
▴
Re: [LTP] [PATCH] Fix Cron Test Fails to Compare
|
From: Subrata M. <su...@li...> - 2008-10-29 08:49:49
|
On Tue, 2008-10-28 at 21:49 -0700, CAI Qian wrote:
> Hi,
>
> This patch fixes a comparison failure spotted by Elder Costa because
> the script was generating empty files.
>
> Signed-off-by: CAI Qian <ca...@cc...>
Thanks. This along with Elder´s:
Patch: cron_tests.sh
is merged. Please see my observations before and after patching:
==========================================
Before Patching
==========================================
<<<test_output>>>
incrementing stop
cron01 0 INFO : Test #1: crontab <filename> installs the crontab
file
cron01 0 INFO : Test #1: cron schedules the job listed in
crontab file.
cron01 0 INFO : Test #1: Installing cron job ...
cron01 0 INFO : Test #1: Cronjob installed successfully
cron01 0 INFO : Test #1: /var/log/cron: Trying altenate log...
cron01 0 INFO : Test #1: cron activity logged
in /var/log/messages
cron01 0 INFO : Test #1: Values are good:
\n\t\t Expected 57 \n Received 57
cron01 0 INFO : Test #1: Values are good:
\n\t\t Expected 58 \n Received 58
cron01 0 INFO : Test #1: Values are good:
\n\t\t Expected 59 \n Received 59
cron01 0 INFO : Test #1: Values are good:
\n\t\t Expected 0 \n Received 00
cron01 0 INFO : Test #1: Values are good:
\n\t\t Expected 1 \n Received 1
cron01 0 INFO : Test #1: /var/log/cron: alternate...
cron01 1 PASS : Test #1: installed cronjob, and cron executed
the cronjob.
cron02 0 INFO : Test #2: crontab -r removes the crontab file.
cron02 0 INFO : Test #2: installing crontab file.
cron02 0 INFO : Test #1: /var/log/cron: alternate...
cron02 0 INFO : Test #2: uninstalling crontab file.
cron02 0 INFO : Test #1: /var/log/cron: alternate...
cron02 2 PASS : Test #2: crontab removed the cronjob
cron03 0 INFO : Test #3: crontab -l lists the cronjobs installed
cron03 0 INFO : Test #3: installing crontab file ...
cron03 0 INFO : Test #3: Cron job installed.
cron03 0 INFO : Test #3: crontab -l listed cronjob
tst2_cronprg.sh
cron03 0 INFO : Test #3: uninstalling crontab file.
<<<execution_status>>>
duration=422 termination_type=exited termination_id=0 corefile=no
cutime=7 cstime=16
<<<test_end>>>
==========================================
==========================================
After Patching
==========================================
<<<test_output>>>
incrementing stop
cron01 0 INFO : Test #1: crontab <filename> installs the crontab
file
cron01 0 INFO : Test #1: cron schedules the job listed in
crontab file.
cron01 0 INFO : Test #1: Installing cron job ...
cron01 0 INFO : Test #1: Cronjob installed successfully
cron01 0 INFO : Test #1: /var/log/cron: Trying altenate log...
cron01 0 INFO : Test #1: cron activity logged
in /var/log/messages
cron01 0 INFO : Test #1: Values are good:
\n\t\tExpected 6 \n\t\tReceived 6
cron01 0 INFO : Test #1: Values are good:
\n\t\tExpected 7 \n\t\tReceived 7
cron01 0 INFO : Test #1: Values are good:
\n\t\tExpected 8 \n\t\tReceived 8
cron01 0 INFO : Test #1: Values are good:
\n\t\tExpected 9 \n\t\tReceived 9
cron01 0 INFO : Test #1: Values are good:
\n\t\tExpected 10 \n\t\tReceived 10
cron01 0 INFO : Test #1: /var/log/cron: alternate...
cron01 1 PASS : Test #1: installed cronjob, and cron executed
the cronjob.
cron02 0 INFO : Test #2: crontab -r removes the crontab file.
cron02 0 INFO : Test #2: installing crontab file.
cron02 0 INFO : Test #1: /var/log/cron: alternate...
cron02 0 INFO : Test #2: uninstalling crontab file.
cron02 0 INFO : Test #1: /var/log/cron: alternate...
cron02 2 PASS : Test #2: crontab removed the cronjob
cron03 0 INFO : Test #3: crontab -l lists the cronjobs installed
cron03 0 INFO : Test #3: installing crontab file ...
cron03 0 INFO : Test #3: Cron job installed.
cron03 0 INFO : Test #3: crontab -l listed cronjob
tst2_cronprg.sh
cron03 0 INFO : Test #3: uninstalling crontab file.
<<<execution_status>>>
duration=405 termination_type=exited termination_id=0 corefile=no
cutime=7 cstime=15
==========================================
There are still some issues related to:
\n\t\t
Can you also send a patch fixing them as well ?
Regards--
Subrata
>
> --- cron_tests.sh.orig 2008-10-29 12:42:46.510747851 +0800
> +++ cron_tests.sh 2008-10-29 12:43:50.124748312 +0800
> @@ -178,7 +178,7 @@
> TS_MIN2=$(awk '{print $8}' $LTPTMP/tst1_cron.out |
> awk -F: '{printf("%d", $2);}')
>
> - if [ $TS_MIN2 -ne $TS_MIN1 ]
> + if [ "$TS_MIN2" != "$TS_MIN1" ]
> then
> # if the value of the minute field did not advance by 1
> # flag as failure.
>
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Ltp-list mailing list
> Ltp...@li...
> https://lists.sourceforge.net/lists/listinfo/ltp-list
|