Re: [LTP] Usage fix in memory controller testcase

[Sudhir K. <sk...@li...>]

On Thu, Oct 02, 2008 at 07:00:55PM +0530, Rishikesh K. Rajak wrote:
> 
> Hi Sudhir/Subrata,
Hi Rishi,
> 
> Here you can find one patch which fixes an error in memory controller
> testcase.
I do not find anything that fixes the error you say occured to you.

> 
> 
> Description: The testcase return error when run `run_memctl_test.sh`
> with no argument.
First you need to know what is the use of the variable passed to the
script. It is the test number which is to be run. So If you are doing a
manual testing then you must pass the test number to be run, hence it is
not an error.
Second, if you want to do a manual testing I can put a check on the
parameters received by the script(even you can do it ;)). But always better if
you report the error message too.

> 
> Signed-off By: Rishikesh K Rajak <ris...@li...>
> ---
> Index:
> ltp-full-20080930/testcases/kernel/controllers/memctl/run_memctl_test.sh
> ===================================================================
> ---
> ltp-full-20080930.orig/testcases/kernel/controllers/memctl/run_memctl_test.sh       2008-09-30 18:06:43.000000000 +0530
> +++
> ltp-full-20080930/testcases/kernel/controllers/memctl/run_memctl_test.sh
> 2008-10-02 18:50:23.000000000 +0530
> @@ -39,9 +39,12 @@
>  #
> #
>  #  12/03/08  Sudhir Kumar <sk...@li...>   Created this
> test       #
>  #  11/05/08  Sudhir Kumar <sk...@li...>   Added third
> test        #
> +#  02/10/08  Rishikesh    <ris...@li...> removed usage
> error     #
>  #
> #
> 
> #################################################################################
> 
> +. ./myfunctions.sh
> +
>  export TCID="memctl_test01-03";
>  export TST_TOTAL=3;
>  export TST_COUNT=1;

-- 
Regards
Sudhir Kumar
Linux Technology Center
IBM, India.