From: Subrata <sub...@us...> - 2008-09-10 08:59:43
|
Update of /cvsroot/ltp/ltp/testcases/kernel/syscalls/setgroups In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv25758/ltp/testcases/kernel/syscalls/setgroups Modified Files: Makefile compat_16.h setgroups02.c setgroups03.c Log Message: I worked on 2 test cases for foogid16 system calls; and I will do 5 more. All these test cases have the same macro. So I'd like to introduce compat_gid.h; and put the macro to the file. Could you add compat_gid.h to testcases/kernel/syscalls/utils/ and apply patches for existing test cases? Here after I'd like to use the compat_gid.h in newly ported test cases. Signed-off-by: Masatake YAMATO <ya...@re...>, Index: setgroups03.c =================================================================== RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/setgroups/setgroups03.c,v retrieving revision 1.10 retrieving revision 1.11 diff -C2 -d -r1.10 -r1.11 *** setgroups03.c 27 Aug 2008 12:02:42 -0000 1.10 --- setgroups03.c 10 Sep 2008 08:59:40 -0000 1.11 *************** *** 233,237 **** } ! if (!COMPAT_SIZE_CHECK(user_info->pw_gid)) { tst_brkm(TBROK, cleanup, --- 233,237 ---- } ! if (!GID_SIZE_CHECK(user_info->pw_gid)) { tst_brkm(TBROK, cleanup, Index: Makefile =================================================================== RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/setgroups/Makefile,v retrieving revision 1.8 retrieving revision 1.9 diff -C2 -d -r1.8 -r1.9 *** Makefile 27 Aug 2008 12:02:42 -0000 1.8 --- Makefile 10 Sep 2008 08:59:40 -0000 1.9 *************** *** 17,21 **** # ! CFLAGS += -I../../../../include -Wall LDLIBS += -L../../../../lib -lltp --- 17,21 ---- # ! CFLAGS += -I../../../../include -I../utils -Wall LDLIBS += -L../../../../lib -lltp Index: compat_16.h =================================================================== RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/setgroups/compat_16.h,v retrieving revision 1.1 retrieving revision 1.2 diff -C2 -d -r1.1 -r1.2 *** compat_16.h 27 Aug 2008 12:02:42 -0000 1.1 --- compat_16.h 10 Sep 2008 08:59:40 -0000 1.2 *************** *** 23,43 **** #define __SETGROUPS_COMPAT_16_H__ ! #include <asm/posix_types.h> #include "linux_syscall_numbers.h" /* For avoiding circular dependency. */ extern void cleanup(void); #ifdef TST_USE_COMPAT16_SYSCALL - typedef __kernel_old_gid_t GID_T; - - int - COMPAT_SIZE_CHECK(gid_t gid) - { - /* See high2lowgid in linux/highuid.h - Return 0 if gid is too large to store - it to __kernel_old_gid_t. */ - return ((gid) & ~0xFFFF)? 0: 1; - } long --- 23,34 ---- #define __SETGROUPS_COMPAT_16_H__ ! #include "compat_gid.h" #include "linux_syscall_numbers.h" + /* For avoiding circular dependency. */ extern void cleanup(void); #ifdef TST_USE_COMPAT16_SYSCALL long *************** *** 65,69 **** for (i = 0; i < size16; i++) { ! if (!COMPAT_SIZE_CHECK(list32[i])) tst_brkm(TBROK, cleanup, --- 56,60 ---- for (i = 0; i < size16; i++) { ! if (!GID_SIZE_CHECK(list32[i])) tst_brkm(TBROK, cleanup, *************** *** 78,83 **** #else - typedef gid_t GID_T; - int SETGROUPS(size_t size, const GID_T *list) --- 69,72 ---- *************** *** 92,100 **** } - int - COMPAT_SIZE_CHECK(gid_t gid) - { - return 1; - } #endif /* TST_USE_COMPAT16_SYSCALL */ --- 81,84 ---- Index: setgroups02.c =================================================================== RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/setgroups/setgroups02.c,v retrieving revision 1.5 retrieving revision 1.6 diff -C2 -d -r1.5 -r1.6 *** setgroups02.c 27 Aug 2008 12:02:42 -0000 1.5 --- setgroups02.c 10 Sep 2008 08:59:40 -0000 1.6 *************** *** 188,192 **** } ! if (!COMPAT_SIZE_CHECK(user_info->pw_gid)) { tst_brkm(TBROK, cleanup, --- 188,192 ---- } ! if (!GID_SIZE_CHECK(user_info->pw_gid)) { tst_brkm(TBROK, cleanup, |