Re: [LTP] [PATCH] realtime is architecture specific

[Martin H. <err...@mp...>]

Thanks for the info. I'll try the intermdiate April release then.
Yes, my patch did not consider cross-compiling.

Martin

On Mon, Apr 28, 2008 at 12:26:25PM +0530, Subrata Modak wrote:
> On Sun, 2008-04-27 at 13:47 +0100, Martin Habets wrote:
> > The realtime test suite has some architecture specific code in it,
> > and results in build errors on those not supported.
> > This makes it build only for the architectures supported.
> 
> And i think we already have this Fix in LTP in April. Chirag sent across
> a Patch in April 08 for this. Chirag, what do you say for the
> following ?
> 
> Regards--
> Subrata
> 
> And mike replied back to this mail:
> 
> > +ARCH = $(shell uname -m)
> 
> ugh, no.  LTP should never ever execute `uname` or any similar thing in
> any 
> Makefile.  this breaks cross-compilation and is generally flaky (i see
> you 
> attempt to consider this by only doing a partial string match on the
> output).
> 
> -mike
> 
> > 
> > Martin
> > 
> > 	Signed-off-by: Martin Habets <err...@mp...>
> > 
> > Index: ltp/testcases/realtime/Makefile
> > ===================================================================
> > --- ltp.orig/testcases/realtime/Makefile	2008-04-27 13:28:34.000000000 +0100
> > +++ ltp/testcases/realtime/Makefile	2008-04-27 13:28:49.000000000 +0100
> > @@ -2,7 +2,11 @@
> >  srcdir := .
> >  include $(srcdir)/config.mk
> > 
> > -SUBDIRS = lib func perf stress
> > +ARCH = $(shell uname -m)
> > +SUBDIRS =
> > +ifneq ($(findstring $(ARCH),86 ppc),)
> > +SUBDIRS += lib func perf stress
> > +endif
> > 
> >  all:
> >  	@set -e; for i in $(SUBDIRS); do $(MAKE) -C $$i; done
> > 
> > -------------------------------------------------------------------------
> > This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
> > Don't miss this year's exciting event. There's still time to save $100. 
> > Use priority code J8TL2D2. 
> > http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
> > _______________________________________________
> > Ltp-list mailing list
> > Ltp...@li...
> > https://lists.sourceforge.net/lists/listinfo/ltp-list

-- 
Martin
---------------------------------------------------------------------------
30 years from now GNU/Linux will be as redundant a term as MERT/UNIX is 
today. - Martin Habets
---------------------------------------------------------------------------