Re: [LTP] [PATCH][1/17]CPUCONTROLLER: fairness test case 1 and 2

[Sudhir K. <sk...@li...>]

Hi SUbrata,

On Thu, Feb 28, 2008 at 09:39:18PM +0530, Subrata Modak wrote:
> On Thu, 2008-02-28 at 16:34 +0530, Subrata Modak wrote:
> > On Thu, 2008-02-28 at 16:21 +0530, Dhaval Giani wrote:
> > > On Thu, Feb 28, 2008 at 10:05:21AM +0530, Sudhir Kumar wrote:
> > > > Hi
> > > > 
> > > > This patch creates the framework for controllers testcases in LTP. This also
> > > > creates the first and second testcase for cpu controller and adds some
> > > > documentation.
> > > > 
> > > 
> > > Hi Sudhir,
> > > 
> > > This is a very big patch, you might want to split it into 3 different
> > > patches, one for the framework and one for each testcase.
> > 
> > Thanks Dhaval for reviewing and providing comments.
> > 
> > Sudhir,
> > 
> > We will wait for all review comments from Dhaval and then you can make
> > the necessary changes. Let Dhaval finally ack all your changes after
> > which we can integrate this to LTP. Let cpu controller test cases go
> > during March 2008 release of LTP.
> > 
> > Also, one comment i have is, you might have missed to include the
> > Copyright and License declarations in few of the source code. Just check
> > them whenever you are re-sending worked out patches.
> 
> Well Sudhir,
> 
> I decided to revoke the decision by myself, keeping in mind the fact
> delay in release can cause for testing. So, i have decided to include
> your PATCHES in this release itself. Since Dhaval did not mention major
> technical anomaly(s)for the same, i find it prudent to go ahead in
> including the same in this release. All your 17 patches has been duly
> merged and you will see them in tomorrowś release.

Thank you so much.
This will keep me involved in more test cases development. 
> Please note down all Dhavalś review comments and include them in your
> next round of cleanups, either from you or from somebody else. Thanks
> again for these new test cases. Expecting more from you in future.
For sure I will take care of all the comments and further cleanups and
requirements. Soon I will send a new patch correcting that all.

Thanks

Sudhir
> 
> Regards--
> Subrata
> 
> > 
> > Regards--
> > Subrata
> > 
> > > 
> > > Minor comments follow,
> > > 
> > > > <cpuctl1.patch>
> > > > 
> > > > Signed-off-by: Sudhir Kumar <sk...@li...>
> > 
> > 
> > -------------------------------------------------------------------------
> > This SF.net email is sponsored by: Microsoft
> > Defy all challenges. Microsoft(R) Visual Studio 2008.
> > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> > _______________________________________________
> > Ltp-list mailing list
> > Ltp...@li...
> > https://lists.sourceforge.net/lists/listinfo/ltp-list
>