Re: [LTP] update filecaps test

[Serge E. H. <se...@us...>]

Quoting Andrew G. Morgan (mo...@ke...):
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Serge E. Hallyn wrote:
> | Good point.  Though note that the cap_to_text manpage is confusing here
> | - do i free(capstxt), or do I cap_free(cap) as the manpage implies and
> | automatically free capstxt that way?  Reading the manpage on my system
> | kind of implies that so long as I cap_init at the start and
> | cap_free(cap) at the end, capstxt will be freed at the end...  Though
> | that's probably not right.
>
> cap_free() should be used for both strings and capabilities (ie.,
> anything) allocated by libcap.

Oh!

I see :)  Ok, will fix that.  thanks.

> I'll make the cap_to_text documentation more explicit.

Yeah, even that aside we do need to make a list of the capability
manpages needing updates.  I wasn't going to feel that was urgent
until your per-process issecure patch made it into Linus' tree,
but with capability bounding sets now there I need to at least
start...

thanks,
-serge