Re: [LTP] [PATCH 2/6] PID Namespace testcase

[Serge E. H. <se...@us...>]

Quoting Nate Straz (nat...@re...):
> On Thu, Dec 27, 2007 at 08:58:36AM -0600, Serge E. Hallyn wrote:
> > Quoting Rishikesh K. Rajak (ris...@li...):
> > > +	tst_resm(TINFO, "PIDNS test is running inside container\n");
> > > +	if(( cpid == CHILD_PID) &&
> > > +		( ppid == PARENT_PID ) )
> > > +	{
> > > +                tst_resm(TPASS, "Success:" );
> > > +	}
> > > +	else
> > > +	{
> > > +		tst_resm(TFAIL, "FAIL: Got unexpected result of"
> > > +			" cpid=%d ppid=%d\n", cpid, ppid);
> > > +	}
> > 
> > I'm still dubious - if this testcase fails, won't LTP claim all tests
> > pssed?
> > 
> > Yes the logs will have a FAIL message but one generally doesn't look at
> > those if all tests reported as passed.
> > 
> > So can someone confirm that LTP should report a failed test case the way
> > this is done?  (My own quick test suggests no)
> > 
> > > +	tst_exit();
> 
> The magic is in this function.  It uses T_exitval to determine the exit
> status of the test program.  This is set in tst_res().

I've tried doing 'tst_resm(TFAIL, ') in a dummy test program and
then tst_exit(), but 'runltp -s containers' reported all tests failed.

But I'll take your word for it and assume it was some error in my test
then :)

thanks,
-serge