[LTP] [ ltp-Bugs-1732287 ] mtest06/mmap1.c missing run_once check in do loop

[SourceForge.net <no...@so...>]

Bugs item #1732287, was opened at 2007-06-06 11:32
Message generated for change (Comment added) made by jerrywei
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=103382&aid=1732287&group_id=3382

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Testcases
Group: Memory
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: wei (jerrywei)
Assigned to: Nobody/Anonymous (nobody)
Summary: mtest06/mmap1.c missing run_once check in do loop

Initial Comment:
In line 659 of mtest06/mmap1.c in ltp-full-20070531, it
should be
  }while (TRUE && !run_once);
instead of
  }while (TRUE);

So it will check the case of run_once in do loop.

Also, line 410 of fprintf command will be better to put
before the while loop to avoid excessive same messages.

----------------------------------------------------------------------

>Comment By: wei (jerrywei)
Date: 2007-06-12 07:11

Message:
Logged In: YES 
user_id=1139389
Originator: YES

If the default value was changed, then all files used mmap1 such as
runtest/mm, runtest/ltplite, also need to be changed accordingly.


----------------------------------------------------------------------

Comment By: rsalveti (rsalveti)
Date: 2007-06-12 06:44

Message:
Logged In: YES 
user_id=1269623
Originator: NO

Hm, I got it now.

I guess that you want the test to run at the same way as before:
At ltp-20070430 when you run test mmap1 without passing anything, the test
just run it once and exit, but, at ltp-20070531 when you do this it'll run
for, at least, 24 hours.

Running for 24 as the default value is what sound correct to me, because
without this we don't need the default '-x' value (it'll run only once and
exit).

What do you think about this?

----------------------------------------------------------------------

Comment By: rsalveti (rsalveti)
Date: 2007-06-11 21:11

Message:
Logged In: YES 
user_id=1269623
Originator: NO

The only thing here that makes sense is moving the fprintf at line 410 to
get better output.

About the run_once, if you see at the code, we're not using it anymore,
because when you don't pass the flag '-x' the test will run for 24 hours
and if you put the code (TRUE && !run_once) the test will run and exit at
the same time.

And also, please feel free to send any patches to our mailing list.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=103382&aid=1732287&group_id=3382