Re: [LTP] Don't hardcode constants in fchownat01

[Mike F. <va...@ge...>]

On Sunday 27 August 2006 18:15, Jeff Bailey wrote:
> Why?  The common header that defines them is asm/unistd.h, pulled in
> through sys/syscall.h.

even better would be to just use the symbol from the system libc ... but th=
at=20
has the same problems as using outdated kernel headers

> Is the concern about systems that haven't updated their kernel headers?

yes, which is why if you just wrap the stuff in '#ifndef __NR_openat...' it=
=20
should be fine

> I think it's a mistake to hardcode these values when it's trivial to
> install the right headers when a new kernel is installed, especially
> given that (I believe) all major distros have now switched to a
> standardised header set.

that's why you make them a fallback, not the default
=2Dmike