From: Andi K. <ak...@su...> - 2003-03-01 19:30:41
|
On Sat, Mar 01, 2003 at 11:17:31AM -0800, Martin J. Bligh wrote: > > > --On Friday, February 28, 2003 23:32:32 +0100 Andi Kleen <ak...@su...> wrote: > > >> fs/dcache.c: In function `dcache_seq_show': > >> fs/dcache.c:1675: warning: long unsigned int format, unsigned int arg (arg 3) > >> make[1]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. > >> fs/built-in.o(.text+0x164da): In function `dcache_seq_next': > >> : undefined reference to `__divdi3' > >> make: *** [.tmp_vmlinux1] Error 1 > > > > I only tested on x86-64 sorry which has 64bit division of course. > > > > Just casting the *pos in dcache_seq_next to u32 should do the trick as we > > don't care about large file support for that file > > OK, that fixed it - thanks. Pretty much equivalent, if anything, it's > a tad slower, but hardly measurable. Is that comparing to the previous patch or straight 2.5.63 ? If it's "only in the noise slower" I would consider it a win already because it uses much less memory than the old code. -Andi |