[ loki-lib-Bugs-3224591 ] SmartPtr: DeepCopy and ArrayStorage are not compatible

[SourceForge.net <no...@so...>]

Bugs item #3224591, was opened at 2011-03-18 19:56
Message generated for change (Settings changed) made by rich_sposato
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=396644&aid=3224591&group_id=29557

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Closed
Resolution: Wont Fix
Priority: 5
Private: No
Submitted By: https://www.google.com/accounts ()
>Assigned to: Richard Sposato (rich_sposato)
Summary: SmartPtr: DeepCopy and ArrayStorage are not compatible

Initial Comment:
DeepCopy ownership policy and ArrayStorage storage policy are not compatible, because only the first element in array gets copied by Clone() function of the pointee.

#include <Loki/SmartPtr.h>

struct Foo {
    Foo* Clone() const { return new Foo(*this); }
};

int main() {
    typedef Loki::SmartPtr<Foo, Loki::DeepCopy, Loki::DisallowConversion,
        Loki::AssertCheck, Loki::ArrayStorage> Ptr;
    Ptr ptr(new Foo[23]);
    Ptr ptrCopy(ptr);  // only first element is copied
}

I think there should be a partial specialization disallowing this combination of policies.

----------------------------------------------------------------------

Comment By: Richard Sposato (rich_sposato)
Date: 2011-09-21 16:07

Message:
There are multiple problems with attempting to fix this problem.

One is that C++ does not allow partial specializations of functions inside
template classes. Section 1.4 of Modern C++ Design says "Specialization of
member functions does not scale. You can specialize any member function of
a template with one template parameter, but you cannot specialize
individual member functions for templates with multiple template
parameters."


The second problem has to do with making any array of objects where each
element in the new array is a copy of its counterpart in the source array.
If we use the array new operator, (e.g. - new T[ itemCount ]; ), that will
just call the default constructor of type T - not the copy constructor for
each element in the source array.

I can add a comment to DeepCopy and ArrayStorage policies classes saying
that each should not be used with the other. That's probably the best we
can do here.

Cheers,

Rich

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=396644&aid=3224591&group_id=29557