[ loki-lib-Patches-1833993 ] Eliminate warnings and errors with gcc-4.3-20071109

[SourceForge.net <no...@so...>]

Patches item #1833993, was opened at 2007-11-18 06:18
Message generated for change (Comment added) made by tbrowder2
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=396646&aid=1833993&group_id=29557

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Tom Browder (tbrowder2)
Assigned to: Nobody/Anonymous (nobody)
Summary: Eliminate warnings and errors with gcc-4.3-20071109

Initial Comment:
I just got gcc-4.3-20071109 snapshot built and started to use it and soon discovered that it finds more problems than 4.2.1, including errors with loki-lib.  I copied my loki-lib directory (which is synched with sourceforge) to loki-lib_gcc4.3 where I tried to eliminate all the errors and warnings (some warnings I ignored per Andrei's embedded instructions and for others I had to turn off
certain warning flags). I have attached a patch from running:

  diff -Naur -x.svn loki-lib loki-lib_gcc4.3

-Tom

Tom Browder
Niceville, FLorida
USA

----------------------------------------------------------------------

>Comment By: Tom Browder (tbrowder2)
Date: 2008-04-24 04:42

Message:
Logged In: YES 
user_id=861162
Originator: YES

OK, the changes suggested by zak-k worked.  Attached is a corrected patch
from running svn diff in my updated working directory.

File Added: Loki-lib.patch.gcc4.3.corrected

----------------------------------------------------------------------

Comment By: Zak Kipling (zak-k)
Date: 2008-04-23 06:32

Message:
Logged In: YES 
user_id=764271
Originator: NO

I get errors there too -- I think it needs Loki:: qualifications on the
nested Factory and Key typedefs in CachedFactory.h (lines 665 and 692) in
order to be valid according to the stricter scoping rules in 4.3.

----------------------------------------------------------------------

Comment By: Tom Browder (tbrowder2)
Date: 2008-04-23 06:12

Message:
Logged In: YES 
user_id=861162
Originator: YES

Hm, after updating my loki with svn, and making the changes from
<string.h> to <cstring>, I can build static and shared, but I'm now having
a problem compiling test/CachedFactoryTest.

I'll report back after I figure that one out.

----------------------------------------------------------------------

Comment By: Tom Browder (tbrowder2)
Date: 2008-04-23 03:49

Message:
Logged In: YES 
user_id=861162
Originator: YES

I believe you're correct.  I'll go back, make those changes, make sure the
changes compile, and attach the corrected patch.

----------------------------------------------------------------------

Comment By: Zak Kipling (zak-k)
Date: 2008-04-22 06:50

Message:
Logged In: YES 
user_id=764271
Originator: NO

Several of these patches add

  #include <string.h>

in order to get global-namespace declarations of strlen, strcmp and
friends.


Isn't this deprecated in Annex D of the standard, in favour of

  #include <cstring>

with the names qualified as std::strlen etc?




----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=396646&aid=1833993&group_id=29557