Re: [Lmuse-developer] spinbox craziness continues

[Tim E. R. <ter...@ro...>]

On December 12, 2011 10:25:21 AM Geoff Beasley wrote:
> fellas, a spinbox is there for adding an integer. it only needs focus
> when inputting data. once you press enter focus HAS to go back to the
> main canvas. the track info pane works but the box remains blue -
> looking like it still has focus, tho it doesn't - which is good, but
> gives the wrong impression.

Observed. Last edited box remains blue even after clicking inside
 another box. Too odd.

> 
>   the master editor is particularly bad. when you enter a number in any
> of the spinboxes, the number changes immediately but focus just stays
> there _until_ you click down on the main drawing canvas - then focus is
> moved. this is unintuitive and makes work unnecessarily. same in the
> pianoroll as well.

Observed.

> 
> can we finally change this behaviour so that when you input a number
> then press enter ( or mouse click or..), the box loses focus, changes
> from blue to white background and the number is entered AND focus moves
> back to the main window whatever that is at the time? and do this for
> all spinboxes in Muse for consistency?
> 
> btw, when in the master editor, spacebar wont start/stop play anymore -
> it used to.

Yes, I've noticed a few places the transport keys don't have focus.

I will take a look but I can't guarantee much right now. 

The problem with focusing is it's very hard to debug in an app like this
 where custom behaviour is used - for example passing shortcut keys onto
 the transport from other windows. I'm sure Robert and Flo can attest to that.
Couple that with the desire for sane tabbing, and it's tough.

Recall that after the move to Qt4, what used to work fine in MusE-1
 suddenly was so f*d up it took us several months to clear up.
I did heavy battle with those demons and helped make it mostly work.
Qt4 was different enough to cause all these headaches.
Then Robert tried some more, then Flo I think.

Consider also that sometimes, one just wants to quickly try different 
 numbers in a box, followed by enter, without it losing focus each time.
I can tell you that was a strong 'pull from the other end of the rope'
 when I was in there fixing long ago in MusE-1. 
It was kind of conflicting, which way do we choose, for certain boxes? 

The master track for example is just standard behaviour when you slap a
 box onto a form when designing the thing - that is no one has put the 
 necessary code in to /tell/ it that the canvas should get focus after 
 enter is pressed.
That's the thing - it has to be told who gets focus. That's not always easy
 when we have canvases within windows within canvases within windows etc.
I know the others can attest to this. It was tough in Arranger and Pianoroll.
See? This *is* the much hated 'custom behaviour', yet is actually required 
 to make it do these things.

Cheers. Tim.

> 
> best
> 
> g