From: Tim E. R. <ter...@ro...> - 2011-09-11 17:01:06
|
On September 11, 2011 03:06:36 am Orcan Ogetbil wrote: > On Sat, Sep 10, 2011 at 5:39 AM, Robert Jonsson wrote: > > Oh, didn't try the new before I commented. > > > > Here's a new screenshot. > > http://dl.dropbox.com/u/7739312/museshot_sep2011_2.png > > It looks different. Most of the meters are much better but some are > > still to round for my liking so perhaps you are right they are > > partially hidden. I like the cut ones better though :) > > > > About the random color indications, no idea if it is useful but it > > looks really cool, great stuff! > > > > Regards, > > Robert > > > > 2011/9/10 Robert Jonsson <spa...@gm...>: > >> Hi Orcan > >> > >> 2011/9/8 Orcan Ogetbil <oge...@gm...>: > >>> On Thu, Sep 8, 2011 at 2:58 PM, Robert Jonsson wrote: > >> > >> <..> > >> > >>>> Maybe the problem is that the top is more rounded than the bottom? > >>>> Yes, I think that is it. That's why the Gain Reduction is strange too. > >>>> Could you change all corners to look like the bottom ones? > >>> > >>> Is this for the meter or for the slider? I don't think I use different > >>> methods for rounding different ends though. Could it be that the > >>> widget is too long to display in the allocated space and it gets cut > >>> off for you? > >> > >> This is the meter I'm talking about. > >> > >>>> For the slider my comment is basically the same but with gradients. Is > >>>> it possible to only do the gradient at the sides and keep the middle > >>>> flat? > >>> > >>> Hmm, I am not sure if I understood this correctly, could you be a > >>> little more specific? Maybe a mockup? > >> > >> Heh, I tried and failed miserably ;) so I will try to explain a bit > >> better. Ehmm... did I infact not link the screenshot I uploaded? (palm > >> to face) ... that COULD help... > >> > >> If you have a look at this screenshot it will be easier to > >> understand... and also if our systems draw the widgets differently. > >> http://dl.dropbox.com/u/7739312/museshot_sep2011.png > >> > >> The gain reduction is hopefully more evident what I mean now, the > >> green meter in one of the plugins, it is strangely non symmetric. To > >> me it looks like top and bottom are drawn differently... > >> > >> If you have a look at the first input strip on Mixer A and compare the > >> rounding at the top of the Slider and the Meter. I think the rounding > >> at the top of the Slider is much better than the Meter. I guess it's > >> possible the widget is too big and cut at places but it doesn't look > >> like that to me. > >> > >> Last, about the gradient. Used this way the gradient gives a kind of > >> 3d effect that the Slider is round out of the screen, I like the > >> effect but I think it would look better if the gradient only affected > >> the outmost ~5 pixels and that the middle would be a single colour to > >> give the feeling there is a flat surface in the middle. > >> > >> I hope that was easier to understand even if I can't make a mockup ;) > > Okay, I understand now what you mean (the second screenshot is broken > by the way) with the rounding. > > When I look at my screen, the rounding difference between top and > bottom is there, however it is not as obvious as it is on your > screenshot. > > It turns out that the reason is about smoothening. For the meter I do > the rounding in resizeEvent() via QWidget::setMask(rounded_rectangle). > Because of this, there is no antialiasing. We need to do the rounding > in paintEvent(), but when I do it that way, the rounded edges will > have a black background color, because of the > > setAttribute(Qt::WA_OpaquePaintEvent); > > attribute. Tim says we need this otherwise the painting goes painfully > slow. I will work on finding a way to make both sides happy :) This is only if the intention is do do all the drawing including background yourself. It was absolutely required in class View because when told to ::scroll() a small amount, View's paintEvent would request the /entire/ contents be redrawn. But come to think of it, stuff like meters don't use the ::scroll(). So now I wonder whether it's required there, and in a few other places I added it. Will check some more. I think I may have checked already, but: A simple check is to put a printf line in the particular widget's paintEvent to see exactly what the requested draw rectangle size is. If it's the entire area, even on what should be small areas (small cover-ups), that's bad. Tim. > > As for the flattening the top of the slider, could you try the > attached patch, and play with those parameters you find in the patch? > I couldn't manage to find a combination to make it look good. Maybe > you have a better idea. > > Orcan |