Re: [Lmuse-developer] flam?

[Luis G. <lui...@us...>]

On Sun, Apr 17, 2011 at 11:17 PM, Tim E. Real <ter...@ro...> wrote:
>  proxy()->drawPrimitive(QStyle::PE_FrameFocusRect, &fropt, p, widget);
>  to just
>  drawPrimitive(QStyle::PE_FrameFocusRect, &fropt, p, widget);
>
> I think that's what you would have done there.

Right in one. Committed the change.

> So you changed QProxyStyle to QWindowsStyle, eh?
> I hope it's not dumbing down any /future/ features just for my Qt4.5's sake.

Nothing too serious. ProxyStyle is a bit more respectful with the
users' preferred style as configured with qtconfig, but I expect
someone using flam's MovieKnob style will also use some heavy qss
modifications, so not much of the base style should be left around
anyway. QWindowsStyle is as good as any other one, I guess, and it is
guaranteed to exist in any platform supported by Qt.

> If so, please for your sake, go back to QProxyStyle.
> Seriously, we can put some #ifdef 's to detect Qt version for the odd use
>  of QProxyStyle...
> But I imagine you don't want to start having to use them all over the place

Yup, that's more or less like it. As I said, no big deal, and I like
to keep my VIP customers happy :-).

Luis