From: Orcan O. <oge...@gm...> - 2010-10-22 05:28:39
|
Ah, my email bounced because my patch was too big. I uploaded it at http://oget.fedorapeople.org/muse2/muse2-cmake.patch.Oct21 Below you can read the actual email that came with it. Orcan On Fri, Oct 22, 2010 at 1:24 AM, Orcan Ogetbil wrote: > On Thu, Oct 21, 2010 at 3:24 AM, Orcan Ogetbil wrote: >> On Wed, Oct 20, 2010 at 11:07 PM, Tim E. Real wrote: >>> On October 20, 2010 09:34:01 pm Orcan Ogetbil wrote: >>>> Are you on >>>> Freenode anywhere? >>> That's chat? I'm a bit old school, chatted once or twice. Hated the typing. >>> Bit chaotic for me I guess, but is a useful thing to collaborate real time... >> >> It is an IRC server with many channels, commonly used by free software >> folks. I find it useful when multiple people are working on the same >> subject. Some people like it, some don't. I was just wondering. >> >>>> Please let me know if there is anything I can do for you. >>>> >>>> Orcan >>>> >>> Always open to patches here. If you can fix anything you see wrong >>> or suggest solutions, great. >>> >> >> Sure. I worked on it tonight. Now I am attaching a patch I made >> (against SVN revision 480). I cleaned up the main CMakeLists.txt file >> a little bit. The following changes are made: >> >> - cmake has its own pkgconfig facility. No need to add an external >> file to use pkgconfig. I dropped "cmake/UsePkgConfig1.cmake" and fell >> back to cmake's native way of handling pkgconfig. You can probably >> remove the commented out configure.ac bits from the main >> CMakeLists.txt file now. >> >> - At the end of cmake, now there is a nice summary of what components >> will be built, and what will not. But this feature adds a new file >> "cmake/Summary.cmake". >> >> - Enabled lash, osc(liblo), dssi support. The last 2 looked like they >> were enabled, but really they were not. >> >> - Some parts of muse depends on the stuff from the widgets/ directory. >> Thus the widgets/ stuff needs to be built first. Otherwise one might >> get build errors like Alex did because of unmet dependencies between >> internal libraries. Stuff can be put in order via the >> add_dependencies(target src) function. I added this to a couple places >> where I was sure there is some dependency chain. But I might have >> missed some since I can't predict what order cmake will build stuff >> unless you tell it. >> >> Feel free to take what you want from my patch. >> > > I did some more work on cmake. In addition to the above changes, the > attached patch also does: > > - Enable "make uninstall". > > - I renamed the muse executable to muse2. I believe that now muse2 > will be parallelly installable with muse1. > > - Install stuff in packaging/ utils/ and demos/. Note that I added new > CMakeLists.txt files into these directories. > > - Some minor fixes (change hardcoded paths into variables) > > The patch can be applied to SVN 480 or 481. Please test and see how things are. > > Orcan > |