Re: [Lksctp-developers] [PATCH 0/4] New interface for memory accounting (take 1)

[David M. <da...@da...>]

From: Hideo AOKI <ha...@re...>
Date: Sun, 30 Dec 2007 03:47:33 -0500

> Hello,
> 
> This patch set introduces new memory accounting interface.
> Current interface is written for stream protocols only.
> To enable memory accounting in other protocols (e.g. UDP),
> I enhanced the interface and updated TCP and SCTP memory
> accounting.
> 
> The patch set consists of the following 4 patches.
> 
> [1/4] introducing new memory accounting interface
> [2/4] adding memory accounting points to consolidate functions
> [3/4] updating TCP to use new interface
> [4/4] updating SCTP to use new interface
> 
> The patch set was tested on net-2.6.25 tree.

I like this work very much and will add this to net-2.6.25
But I will have to combine it all into one patch.

You cannot have one patch which breaks the build in any way.  All of
the kernel must build properly after each patch in your patchset is
applied.

Since patch 1 renames all of the sk_stream_*() functions, TCP and SCTP
stop building.

We enforce this rule, otherwise when users try to use "git bisect" to
find out where regressions are added, they will get stuck in places
like this where the tree will not build due to such careless
changesets.

Thank you.