Menu
▾
▴
RE: [lkcd-devel] lcrash: search command broken?
|
From: Tom M. <tj...@sg...> - 2006-05-09 20:04:39
|
Actually, the check for a zero faddr is an attempt to see if any chunks of valid
physical memory were found. The faddr variable is assigned a value of zero (0)
on entry. If we get to the end and it's still zero, then we didn't find any
valid chunks... except for the case you mention (for systems where physical
address zero is valid). Perhaps it would be better to set a local flag to false
and turn it to true after faddr is set.
> -----Original Message-----
> From: lkc...@li... [mailto:lkcd-devel-
> ad...@li...] On Behalf Of Michael Holzheu
> Sent: Tuesday, May 09, 2006 5:38 AM
> To: lkc...@li...
> Subject: [lkcd-devel] lcrash: search command broken?
>
> In the lcrash "search" command, we currently assume,
> that a start address of zero is invalid. On s390 this
> is a valid physical memory address. Do we really need
> this check?
>
> Here the code fragment from cmd_search.c:
>
> if (MIP->core_type == dev_kmem) {
> live_again:
> nbytes = size;
> while (nbytes) {
> if (kl_valid_physmem(naddr, nbytes)) {
> faddr = naddr;
> goto done;
> }
>
> [snip]
>
> done:
> /* XXX This check is probably broken, right? */
> if (faddr == 0) {
> return(1);
> }
> if (found_bad_page) {
> /* The last page checked was bad. Make
> * sure that we trim off the bytes from the
> * bad page (assuming that we did not start on
> * a page boundry).
> */
>
>
> Michael
>
>
> -------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> lkcd-devel mailing list
> lkc...@li...
> https://lists.sourceforge.net/lists/listinfo/lkcd-devel
|