From: Matt D. R. <ya...@ap...> - 2002-11-21 10:07:16
|
On Wed, 20 Nov 2002, Bharata B Rao wrote: |>Essentially we used the following criteria |> |>- Unconditional inclusion of headers |>- Unconditional function/variable definition changes if the |> behaviour is not altered without DUMP |>- Clean, but a bit extra code when DUMP is not configured |> is preferred over making the code conditional |> |>As Matt pointed out this was done with the hope of getting lkcd into |>the kernel. It should be a fairly minor process to add the #ifdefs back around the variable code, and perhaps the dump_ipi() stuff as well. I'm not sure about how we exclude <dump.h> except to put: #ifndef _DUMP_H #if defined(CONFIG_CRASH_DUMP) || defined(CONFIG_CRASH_DUMP_MODULE) /* header code here */ #endif #endif Other than that, shouldn't take too long. This is something we can do once the files are in CVS (I'm working on it). --Matt |>However, I would think that it is more easier to have dump specific |>code within CONFIG_CRASH_DUMP till the time it remains outside the |>kernel. |> |>Regards, |>Bharata. |> |> |>------------------------------------------------------- |>This sf.net email is sponsored by: To learn the basics of securing |>your web site with SSL, click here to get a FREE TRIAL of a Thawte |>Server Certificate: http://www.gothawte.com/rd524.html |>_______________________________________________ |>lkcd-devel mailing list |>lkc...@li... |>https://lists.sourceforge.net/lists/listinfo/lkcd-devel |