Re: system() bug in irexec

[<col...@hi...>]

Hi!

"dg...@su..." wrote:
[...]
>   run-kill xawtv "xawtv-remote exit"

Works fine with bash.

--- Schnipp ---
--- run-kill.orig	Sun Jul  8 10:58:03 2001
+++ run-kill	Sun Jul  8 10:59:56 2001
@@ -1,29 +1,29 @@
-#/bin/sh!
+#! /bin/sh

 MAIN_PROG=$1
-PROGRAM_TO_RUN=`which $1`
+PROGRAM_TO_RUN=`which $MAIN_PROG`
+shift

 if [ -f  /tmp/$MAIN_PROG.flag.run ] ; then
-  echo killing progarm... $1
-  KILLING_COMMAND=`cat /tmp/$1.flag.run`
-  rm -f /tmp/$1.flag.run
+  echo killing progarm... $MAIN_PROG
+  KILLING_COMMAND=`cat /tmp/$MAIN_PROG.flag.run`
+  rm -f /tmp/$MAIN_PROG.flag.run
   exec $KILLING_COMMAND
 else
   if [ -f $PROGRAM_TO_RUN ] ; then
     echo Executing program "$PROGRAM_TO_RUN"

-    $PROGRAM_TO_RUN > nul &
+    $PROGRAM_TO_RUN >/dev/null 2>&1 &

-    if [ "$2" == "" ] ; then
-      PROGRAM_PID=`/sbin/pidof $1`
+    if [ x"$@" == x"" ] ; then
+      PROGRAM_PID=`pidof $MAIN_PROG`
       KILL_COMMAND="/bin/kill $PROGRAM_PID"
     else
-      KILL_COMMAND="$2 $3 $4 $5 $6 $7 $8 $9"
+      KILL_COMMAND="$@"
     fi

     echo Closing command: "$KILL_COMMAND",  will be written in "/tmp/$MAIN_PROG.flag.run"
-    touch /tmp/$MAIN_PROG.flag.run
-    echo $KILL_COMMAND >& /tmp/$MAIN_PROG.flag.run
+    echo $KILL_COMMAND > /tmp/$MAIN_PROG.flag.run

   else
     echo kill-run [program-name]
@@ -32,7 +32,3 @@
     echo
   fi
 fi
-
-
-
-
--- Schnipp ---

Christoph