Re: imon - repeating buttons - patch with fix

[Andreas D. <an...@gm...>]

Am Donnerstag, 2. Juni 2011, um 21.18:20 schrieb Andreas Dick:
> hei Jarod
> 
> another problem I have with the imon panel: all the buttons are repeating,
> except the KEY_VOLUP and KEY_VOLDOWN event from the panel wheel...
> 
> Strange, but KEY_MUTE is only repeating in the syslog (debug=1) but NOT in
> irw... on the other hand, the repeating suppression is verry bad: the first
> time I press the button, the event is allways shown twice, the next time I
> press it, the event is shown only once as expected unless I press another
> button in meantime.
> 
> Well, I digged drivers/media/rc/imon.c and found the part starting with
> 	/* KEY_MUTE repeats from knob need to be suppressed */
> (maybe line 1570)
> 
> So I hacked the code such that
> - the suppression is done of ALL panel events
> - I corrected how the prev_time variable is set, to have really only ONE
> event per button press
> - and I think there is a lock/unlock problem some lines below (but I do not
> understand this well!)
> 
> Please find my new patch attached (it includes my first patch as well)
> Can you please check it and change to your needs?
> Thanks
> Andreas

since 500ms is too long for a convenient repeating suppression, I changed it 
to 250ms... else it is not very handy to use the buttons, and repeating is no 
longer a problem for me now.

But this is kind of personal, I have seen, that ictx->idev->rep[REP_DELAY] was 
changed once from 250 to 500ms, thus I did not touched that and did it hard 
coded for now...

Andreas