Re: [PATCH] Few fixes to me ENE driver

[Maxim L. <max...@gm...>]

On Sun, 2009-08-16 at 16:33 +0200, Christoph Bartelmus wrote:
> Hi!
> 
> Maxim Levitsky "max...@gm..." wrote:
> [...]
> >> How about changing the sample_period to 100. Then there should be no
> >> overflow for the protocols in question and everything should be well,
> >> right?
> > This indeed helps, but 100 isn't that great precision?
> 
> Then let's go down to 75. That should work as well.
> You should also implement the LIRC_GET_REC_RESOLUTION ioctl in your  
> driver. Take a look at lirc_streamzap.c for sample code.
Ok, but I think that recording resolution should be handled by core,
like driver sets it in driver structure, and core returns it.
like features.


Best regards,
	Maxim Levitsky

> 
> > Especially files generated with irrecord might be inaccurate.
> > If you think this is ok, then its isn't a problem to bump it to 100
> 
> The StreamZap receiver has 256 us resolution. 75 should be good enough.
> 
> Christoph
> 
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
> trial. Simplify your report design, integration and deployment - and focus on 
> what you do best, core application coding. Discover what's new with 
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july