Re: Macmini on Hardy Heron

[Mario L. <mar...@gm...>]

Christoph Bartelmus wrote:
> Hi!
> 
> Ken Mandelberg "km...@ma..." wrote:
> 
>> I just upgraded from Ubuntu Gutsy to Hardy this weekend. That caused me
>> to upgrade from lirc .82 to .83 pre 1. I found the macmini behavior to
>> have changed as a result.
> 
> I doubt a bit that really 0.8.3pre1 was used in the Ubuntu package. Please  
> get pre1 and pre2 from lirc.org and report how these behave regarding this  
> issue.
> 
> Christoph
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
> Don't miss this year's exciting event. There's still time to save $100. 
> Use priority code J8TL2D2. 
> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

The version in Ubuntu is indeed 0.8.3~pre1, with a handful of patches added on
as bugs were reported.

The only relevant macmini patch that I see is:

## DP: Flag repeat events on macmini (LP: #179608).

@DPATCH@
diff -urNad lirc-0.8.3~pre1~/daemons/hw_hiddev.c lirc-0.8.3~pre1/daemons/hw_hiddev.c
--- lirc-0.8.3~pre1~/daemons/hw_hiddev.c	2007-10-13 10:41:28.000000000 -0500
+++ lirc-0.8.3~pre1/daemons/hw_hiddev.c	2008-03-24 00:29:22.000000000 -0500
@@ -543,6 +543,11 @@
 	pre_code = 0;
 	main_code = (ev[0].value << 24) + (ev[1].value << 16) +
 	            (ev[2].value <<  8) + (ev[3].value <<  0);
+	if (main_code == 0)
+	{
+		/* some variants seem to send 0 to indicate repeats */
+		main_code = old_main_code;
+	}
 	if (old_main_code == main_code)
 	{
 		repeat_flag = 1;


The original reporter reported that it was added to CVS already on this bug:
https://bugs.edge.launchpad.net/ubuntu/+source/lirc/+bug/179608

-- 
Mario Limonciello
mar...@gm...