Re: [PATCH] Another round of checkpatch formatting fix-ups

[Jarod W. <ja...@wi...>]

Got a warning that this patch was awaiting moderator approval, due to being 
greater than 20K, so I've also posted all my current bits here:

http://people.redhat.com/jwilson/lirc/

You'll see the four patches I've posted this week, the tarball I drop into 
lirc-cvs/contrib/ to export the drivers into a git tree, and a git diff 
generated from said export, which is now in the latest Fedora rawhide 
kernels.


On Thursday 10 January 2008 02:03:58 pm Jarod Wilson wrote:
> Attached is a patch that cleans up another round of warnings and errors
> from the kernel's checkpatch.pl script. With this patch and the other three
> I've posted this week, my export script (to be posted soon) produces a git
> diff that has only three remaining warnings and four remaining errors. The
> errors, as far as I can tell, are bogus, and not really of concern. Not
> sure if there will be complaints about the typedefs.
>
> checkpatch.pl output:
>
> WARNING: do not add new typedefs
> #1309: FILE: drivers/input/lirc/kcompat.h:22:
> +typedef struct class lirc_class_t;
>
> WARNING: do not add new typedefs
> #1371: FILE: drivers/input/lirc/kcompat.h:84:
> +typedef void irqreturn_t;
>
> WARNING: do not add new typedefs
> #1455: FILE: drivers/input/lirc/lirc.h:12:
> +typedef int lirc_t;
>
> ERROR: trailing statements should be on next line
> #7062: FILE: drivers/input/lirc/lirc_imon.c:727:
> +       if (buf[0] == 0x00 &&
>
> ERROR: Macros with complex values should be enclosed in parenthesis
> #9602: FILE: drivers/input/lirc/lirc_mceusb2.c:60:
> +#define DRIVER_AUTHOR  "Daniel Melander <li...@ra...>, " \
>
> ERROR: Macros with complex values should be enclosed in parenthesis
> #9604: FILE: drivers/input/lirc/lirc_mceusb2.c:62:
> +#define DRIVER_DESC    "Philips eHome USB IR Transciever and Microsoft " \
>
> ERROR: Macros with complex values should be enclosed in parenthesis
> #12886: FILE: drivers/input/lirc/lirc_sasem.c:76:
> +#define MOD_AUTHOR     "Oliver Stabel <oli...@gm...>, " \
>
> total: 4 errors, 3 warnings, 17472 lines checked
>
> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.



-- 
Jarod Wilson
ja...@wi...