From: Bengt M. <bu...@be...> - 2007-04-06 09:49:40
|
Hi, I would like to change syntax and semantics of the SEND_STOP directive as follows: Presently, when lircd is repeating $REMOTE and $CODE, to stop the repeating, the command required (e.g. through irsend) is SEND_STOP $REMOTE $CODE The two arguments has to be present, and to match with the arguments used with the SEND_START command that started the repeted send. Otherwise, the command is considered invalid. This requirement is illogical and unnecessary, as lircd can only repeat one ir-code at a time. Proposal: Change to SEND_STOP without arguments. My main motivation is an extension I will send the maintainer shortly. Implementation: --- lirc-0.8.2pre1-orig/daemons/lircd.c 2007-02-20 08:11:10.000000000 +0100 +++ lirc-0.8.2pre1-new/daemons/lircd.c 2007-04-06 11:44:11.000000000 +0200 @@ -1390,12 +1390,9 @@ struct ir_ncode *code; struct itimerval repeat_timer; - if(parse_rc(fd,message,arguments,&remote,&code,NULL,2)==0) return(0); + if(parse_rc(fd,message,arguments,&remote,&code,NULL,0)==0) return(0); - if(remote==NULL || code==NULL) return(1); - if(repeat_remote && repeat_code && - strcasecmp(remote->name,repeat_remote->name)==0 && - strcasecmp(code->name,repeat_code->name)==0) + if(repeat_remote && repeat_code) { int done; |