Re: Driver for Actisys 220L(+)

[<li...@ba...>]

Hi!

"ma...@sp..." wrote:

> On Sat, Dec 17, 2005 at 04:16:00PM +0100, Christoph Bartelmus wrote:
>> Does this really work as a transmitter? You set the serial port to 7N1,
>> but the dongle only supports 8N1. I'm surprised that this will work at
>> all.
> At least for me it does, even without any traces of murphy but you're
> right... I thought LIRC relies on the serial port beeing 7N1 or else

Can you change the code to use 8N1? If you do, please take this fix into  
account, that I just checked in:

diff -u -u -r1.39 lirc_sir.c
--- lirc_sir.c  22 Sep 2005 20:10:37 -0000      1.39
+++ lirc_sir.c  17 Dec 2005 21:09:25 -0000
@@ -827,10 +827,14 @@
        long bytes_out = len / TIME_CONST;
        long time_left;

-       if (!bytes_out)
-               bytes_out++;
        time_left = (long)len - (long)bytes_out * (long)TIME_CONST;
-       while (--bytes_out) {
+       if (bytes_out == 0)
+       {
+               bytes_out++;
+               time_left = 0;
+       }
+       while (bytes_out--)
+       {
                outb(PULSE, io + UART_TX);
                /* FIXME treba seriozne cakanie z drivers/char/serial.c  
*/
                while (!(inb(io + UART_LSR) & UART_LSR_THRE));

Christoph