Re: PATCH: [lirc_i2c] adding kcompat.h and removing most version code

[<li...@ba...>]

Hi!

Jerome Brock "jbr...@ya..." wrote:
[...]
> The patch that follows is my first foray into getting
> one of the drivers positioned for inclusion in the
> kernel sources,  I started with the lirc_i2c driver.
>
> I Added a kcompat.h and moved all version dependant
> code from the lirc_i2c,c driver into this new file.  I
> had to leave the bttv.h include line in the driver.
[...]
> If it looks okay to you, please add to the cvs
> sources.  If it's okay I will move onto lirc_dev.

In general the patch is ok.
The only thing I don't like is that it adds a second kcompat.h in the  
lirc sources. Files with the same name (esp. include files) are a steady  
cause of trouble.

OTOH, the changes can't be included in the already existing kcompat.h  
because then anybody compiling a driver that uses kcompat.h would  
require to have the new I2C layer installed. This is currently not  
acceptable.

But 0.7.0 will be the last release that supports 2.2.x kernels. That  
means once 0.7.0 is released we could add the i2c stuff to the existing  
kcompat.h file.

Jerome, would it be ok for you to resubmit your patch once 0.7.0 is  
released? Any other ideas?

Christoph