Re: [Linuxwacom-devel] [PATCH libwacom 1/2] Allow matching on the name too

[Benjamin T. <ben...@re...>]

On Mar 13 2015 or thereabouts, Bastien Nocera wrote:
> On Fri, 2015-03-13 at 11:30 -0400, Benjamin Tissoires wrote:
> > To support generic tablets, we need to extend the matching pattern 
> > of libwacom. The Huion tablets reuse the same VID:PID accross all of 
> > the products. To be able to differentiate between the models, we can 
> > somewhat
> > rely on the name of the product. It doesn't seem very reliable (for 
> > instance, the H610 Pro and the W58 seems to share the same name), 
> > but it should allow a good amount of them to be added to the DB.
> 
> Changes to gnome-settings-daemon will be necessary if you don't want 
> all the variants to share the same configuration (unless I'm reading 
> this wrong, obviously).
> 
> g-s-d uses "libwacom_get_match()" to uniquify the configuration.

Just tested and that's perfectly fine :)
libwacom_get_match() will return "BUS:VID:PID:NAME" for each device. So
each variant will have its own configuration.


> 
> libwacom_matchstr_to_matches should really use 
> g_key_file_get_string_list() instead of parsing the field by hand by 
> the way.

OK, will amend and send a v2.

Cheers,
Benjamin