From: Ping C. <pin...@gm...> - 2013-01-25 21:44:01
|
Fri, Jan 25, 2013 at 1:05 PM, Kyle Evans <ke...@an...> wrote: > > After reading over your reply and reviewing current code, I may have > > jumped to wrong conclusion of intent of your patch. I was thinking that > > before your patch, the kernel driver was reporting maximum X/Y closer to > > pen's maximums instead of closer to 4096... like Bamboo's and Intuos5's > > were doing. > > > > Now I suspect the current driver is correctly reading thetouch's > > X(max) out of HID report and so reporting X(min/max) of (0,4096). Then > > I suspect its getting really confused on Y(max) (setting logical size to > > 16420 and physical size to garbage values) and so report Y(min/max) of > > (0,garbage). > > > > If you don't mind, could you email the exact X/Y(min,max) values > > reported by X *before* patch to help verify that understanding? > > It is correctly reading XY(min/max) of (0,4096). I see what you mean, > there is no Logical maximum reported for Y, but 16420 doesn't seem to > factor in anywhere. Proportional to the aspect ratio, the dead space is > equal all'round. I see how the subject of this email could confuse the > meaning, but the issue is just that the finger device never outputs > anything close to what it reports as its min & max values, which are > totally different than the pen, which is spot on. > > > > > > > Aside from that, how is the patch, would you guys sign off on it > > after I get some feedback, assuming I can nail down the values? > > > > > > A couple of points: > > > > * If its reading HID wrong, we should somehow come up with a fix for > > that part so its at least correctly report min=0/max=4096 for X/Y. > > * Maybe the values could be further refined based on model # but does > > need some more data points. > > > > I think model # is shared by a lot of unrelated products and so I > > suspect we will have to live with 0-4096 and resulting mm issues and > > rely on calibration to recover from that. > > I don't doubt that the TPC93 has gone into different products, even from > different manufacturers, but I have a hard time believing that those > products have different display sizes, which is the make or break factor > on whether or not these values will work for all of them. Since the pen > is the correct size, I saw no harm in making the finger match. > > I guess the main reason I went this route is that when I tried to > calibrate for the finger, the pen was thrown out of wac because the > calibration tool was not so sophisticated. Phones only have one input > after all. > Fixing the calibration tool is the way to go. > If there is a better way however, such as by using the physical limits > (except I think that is where the problem lies), I would be happy to be > a test case. > We can not fix the physical limit since it is a case by case issue. Offsets are different on different systems.... Ping |