Re: [Linux-NTFS-Dev] Re: unnamed structures

[Anton A. <ai...@ca...>]

On Sun, 29 Feb 2004, Szakacsits Szabolcs wrote:
>   now: 	     a->data_size = cpu_to_le32(le32_to_cpu(a->data_size) + 2);
>   you want:  a->n.data_size = cpu_to_le32(le32_to_cpu(a->n.data_size + 2);
>   could be:  ntfs_attr_datasize_set(a, ntfs_attr_datasize_get(a) + 2);
>
> The last one might be even more simple if it made sense in the future,
>
> 	ntfs_attr_datasize_add(a, 2);

And another problem with this is that all functions beginninf with
ntfs_attr_() operate on ntfs_attr structures and not on ATTR_RECORD
structures.  So you can't use ntfs_attr_*() for such an abstraction
otherwise it would be far too confusing...

Best regards,

	Anton
-- 
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/