Re: [Linux-NTFS-Dev] [Jfs-discussion] [PATCH] fs: cleanup slight list_entry abuse
Development moved to https://sourceforge.net/projects/ntfs-3g/
Brought to you by:
antona,
cha0smaster
From: Rasmus V. <li...@ra...> - 2015-05-12 12:37:55
|
On Thu, Mar 19 2015, Dave Kleikamp <dav...@or...> wrote: > On 03/19/2015 11:11 AM, Boaz Harrosh wrote: >> On 03/19/2015 01:28 PM, Rasmus Villemoes wrote: >>> list_entry is just a wrapper for container_of, but it is arguably >>> wrong (and slightly confusing) to use it when the pointed-to struct >>> member is not a struct list_head. Use container_of directly instead. >>> >>> Signed-off-by: Rasmus Villemoes <li...@ra...> >>> --- >>> Most of these predate git. If I'm the only one who has been confused >>> by this in 10 years, maybe it's not worth the churn. >>> >> >> No you are not alone here. I have seen this once as well but did not have >> the gumption to send a fix. (The sysv.h one) >> >> I totally agree with this patch. (So many of them, bread crumbs of copy/paste >> for you ;0) > > I'm sure that was the case with jfs. > >> >> Reviewed-by: Boaz Harrosh <bo...@pl...> > > Acked-by: Dave Kleikamp <dav...@or...> Al, any chance you'd take this through the vfs tree? Rasmus |