From: Jaya K. <jay...@gm...> - 2008-12-31 20:43:01
|
On Wed, Dec 31, 2008 at 10:16 PM, Yauhen Kharuzhy <je...@gm...> wrote: > On Wed, Dec 31, 2008 at 02:59:36PM +0200, Yauhen Kharuzhy wrote: > >> static int am200_wait_event(struct metronomefb_par *par) >> { >> return wait_event_timeout(par->waitq, gpio_get_value(RDY_GPIO_PIN), HZ); >> } > > I also noticed error in your am200_wait_event() implementation: > > metronomefb supposed that return value of met_wait_event() will be zero > on successful case, but wait_event_timeout() returns zero on timeout. > ah, ok, good catch, I had not noticed this mistake. I will fix this asap or you can also submit a patch to do this if possible. Thanks, jaya |