Re: [Linux-fbdev-devel] [REVIEW PATCH] Added OMAP3EVM support on Tomis FBDEV/DSS Patches

[Koen K. <k....@st...>]

Op 18 nov 2008, om 13:09 heeft Hiremath, Vaibhav het volgende  
geschreven:
>>
>> I finally got rc4 working on evm and with your latest patches I get:
>>
> [Hiremath, Vaibhav] Probably you missed to apply the clock set_rate  
> and round_rate patches by Mans Rullgard.

I already have those, the problem was fixed by:

 From d90a851b63f2593d02ae306a91c36ea059f67014 Mon Sep 17 00:00:00 2001
From: Tomi Valkeinen <tom...@no...>
Date: Mon, 17 Nov 2008 13:40:55 +0200
Subject: [PATCH] DSS: OMAPFB: Check that var->pixclock is not zero

---
  drivers/video/omap2/omapfb-main.c |    6 ++++++
  1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/video/omap2/omapfb-main.c b/drivers/video/omap2/ 
omapfb-main.c
index c0f1664..add65e4 100644
--- a/drivers/video/omap2/omapfb-main.c
+++ b/drivers/video/omap2/omapfb-main.c
@@ -342,6 +342,12 @@ static int check_fb_var(struct fb_info *fbi,  
struct fb_var_screeninfo *var)

  	if (display && display->check_timings) {
  		struct omap_video_timings timings;
+
+		if (var->pixclock == 0) {
+			DBG("Pixclock can't be zero.\n");
+			return -EINVAL;
+		}
+
  		timings.pixel_clock = PICOS2KHZ(var->pixclock);
  		timings.hfp = var->left_margin;
  		timings.hbp = var->right_margin;
-- 
1.6.0.3